Skip to content

chore: add flake8 to precommit hook#593

Merged
JoanFM merged 2 commits intomainfrom
feat-add-flake8
Oct 7, 2022
Merged

chore: add flake8 to precommit hook#593
JoanFM merged 2 commits intomainfrom
feat-add-flake8

Conversation

@samsja
Copy link
Copy Markdown
Member

@samsja samsja commented Oct 7, 2022

Context:

Add flake8 to precommit

@github-actions github-actions bot added the size/s label Oct 7, 2022
@samsja samsja requested a review from alaeddine-13 October 7, 2022 08:56
@JoanFM JoanFM changed the title Feat add flake8 chore: add flake8 Oct 7, 2022
@samsja samsja changed the title chore: add flake8 chore: add flake8 zo precommit hook Oct 7, 2022
@samsja samsja changed the title chore: add flake8 zo precommit hook chore: add flake8 to precommit hook Oct 7, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2022

Codecov Report

Merging #593 (cf472af) into main (376e9fa) will decrease coverage by 0.00%.
The diff coverage is 42.10%.

@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   84.92%   84.92%   -0.01%     
==========================================
  Files         133      133              
  Lines        6708     6714       +6     
==========================================
+ Hits         5697     5702       +5     
- Misses       1011     1012       +1     
Flag Coverage Δ
docarray 84.92% <42.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/find.py 88.65% <0.00%> (ø)
docarray/array/queryset/lookup.py 78.26% <0.00%> (ø)
docarray/array/queryset/parser.py 87.09% <0.00%> (ø)
docarray/array/storage/annlite/helper.py 50.00% <0.00%> (ø)
docarray/document/generators.py 86.32% <0.00%> (ø)
docarray/document/mixins/plot.py 78.91% <0.00%> (ø)
docarray/document/mixins/porting.py 93.15% <0.00%> (ø)
docarray/dataclasses/setter.py 92.15% <33.33%> (-3.68%) ⬇️
docarray/dataclasses/types.py 91.37% <50.00%> (ø)
docarray/document/mixins/multimodal.py 93.33% <50.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added size/xs and removed size/s labels Oct 7, 2022
Copy link
Copy Markdown
Member

@alaeddine-13 alaeddine-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left a minor comment

@samsja samsja changed the title chore: add flake8 to precommit hook chore: add flake8 and blacken docs to precommit hook Oct 7, 2022
@github-actions github-actions bot added size/s and removed size/xs labels Oct 7, 2022
@samsja samsja changed the title chore: add flake8 and blacken docs to precommit hook chore: add flake8 to precommit hook Oct 7, 2022
@samsja samsja enabled auto-merge (squash) October 7, 2022 09:36
@samsja samsja mentioned this pull request Oct 7, 2022
4 tasks
@JoanFM JoanFM disabled auto-merge October 7, 2022 14:53
@JoanFM JoanFM merged commit a11ba60 into main Oct 7, 2022
@JoanFM JoanFM deleted the feat-add-flake8 branch October 7, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants