fix: the file handler is close properly and wrap into a context manager#609
Merged
fix: the file handler is close properly and wrap into a context manager#609
Conversation
JoanFM
approved these changes
Oct 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 133 133
Lines 6715 6715
=======================================
Hits 5703 5703
Misses 1012 1012
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
atm when calling
load_uri_to_audio_tensorwe open a file but don't close it.This PR enforce the closing behavior