Skip to content

fix(array): make docarrays sync when explicitly synced and when exiting context manager only#625

Merged
JoanFM merged 17 commits intomainfrom
fix-array-529
Oct 18, 2022
Merged

fix(array): make docarrays sync when explicitly synced and when exiting context manager only#625
JoanFM merged 17 commits intomainfrom
fix-array-529

Conversation

@Jackmin801
Copy link
Copy Markdown
Contributor

@Jackmin801 Jackmin801 commented Oct 14, 2022

Goals:

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2022

Codecov Report

Merging #625 (0ca7792) into main (ea1ccf2) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 0ca7792 differs from pull request most recent head aa24e2c. Consider uploading reports for the commit aa24e2c to get more accurate results

@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   85.01%   85.07%   +0.06%     
==========================================
  Files         133      133              
  Lines        6745     6720      -25     
==========================================
- Hits         5734     5717      -17     
+ Misses       1011     1003       -8     
Flag Coverage Δ
docarray 85.07% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/annlite/getsetdel.py 100.00% <ø> (ø)
docarray/array/storage/elastic/backend.py 95.52% <ø> (-0.07%) ⬇️
docarray/array/storage/elastic/seqlike.py 95.83% <ø> (+1.83%) ⬆️
docarray/array/storage/qdrant/backend.py 95.95% <ø> (-0.08%) ⬇️
docarray/array/storage/sqlite/backend.py 93.58% <ø> (-0.09%) ⬇️
docarray/array/storage/sqlite/seqlike.py 93.33% <ø> (+9.01%) ⬆️
docarray/array/storage/weaviate/backend.py 88.96% <ø> (-0.08%) ⬇️
docarray/array/storage/weaviate/seqlike.py 92.00% <ø> (+14.58%) ⬆️
docarray/array/document.py 70.76% <100.00%> (ø)
docarray/array/storage/annlite/backend.py 96.00% <100.00%> (-0.06%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remember to clarify in Documentation

Copy link
Copy Markdown
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Documentation about sync intergace

@Jackmin801
Copy link
Copy Markdown
Contributor Author

Jackmin801 commented Oct 18, 2022

Maybe combine into tabs so its more consistent with other sections in the document?

@Jackmin801 Jackmin801 marked this pull request as ready for review October 18, 2022 12:36
Copy link
Copy Markdown
Contributor

@NicholasDunham NicholasDunham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change; otherwise looks good

Co-authored-by: Nicholas Dunham <[email protected]>
Signed-off-by: Jackmin801 <[email protected]>
@JoanFM JoanFM merged commit c962d3c into main Oct 18, 2022
@JoanFM JoanFM deleted the fix-array-529 branch October 18, 2022 14:41
@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-array-529--jina-docs.netlify.app 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants