Merged
Conversation
added 4 commits
October 16, 2022 16:36
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 133 133
Lines 6717 6718 +1
=======================================
+ Hits 5711 5712 +1
Misses 1006 1006
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Can u please show an example of how it looks before and after the change? |
JoanFM
requested changes
Oct 17, 2022
Member
JoanFM
left a comment
There was a problem hiding this comment.
Please, share example of how it looks before and after
Author
|
@JoanFM added in PR description |
JoanFM
approved these changes
Oct 17, 2022
added 2 commits
October 17, 2022 10:14
…/docarray into feat-batch-show-progress
alaeddine-13
approved these changes
Oct 17, 2022
dongxiang123
pushed a commit
that referenced
this pull request
Oct 17, 2022
dongxiang123
pushed a commit
that referenced
this pull request
Oct 17, 2022
dongxiang123
pushed a commit
that referenced
this pull request
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
encodeDocuments by batches. When length of DA is large, say 100k, it's easier to have the progress bar natively builtin docarray to monitor the progress.see it lively:
usage:
import time from docarray import Document, DocumentArray da = DocumentArray() for i in range(1, 100000): da.append(Document(text=str(i))) print('append finished') - for batch in da.batch(500): + for batch in da.batch(500, show_progress=True): time.sleep(0.1)