Skip to content

fix: support qdrant 0.8#635

Merged
JoanFM merged 2 commits intomainfrom
fix-qdrant-support-docarray
Oct 19, 2022
Merged

fix: support qdrant 0.8#635
JoanFM merged 2 commits intomainfrom
fix-qdrant-support-docarray

Conversation

@dongxiang123
Copy link
Copy Markdown
Contributor

@dongxiang123 dongxiang123 commented Oct 17, 2022 •
edited
Loading

Goals:

  • ...This PR is aimed to fix the support for qdrant from Docarray
  • ...
  • check and update documentation, if required. See guide

@dongxiang123 dongxiang123 force-pushed the fix-qdrant-support-docarray branch 2 times, most recently from 73221f8 to ae86cb1 Compare October 17, 2022 09:11
JoanFM
JoanFM requested changes Oct 17, 2022
View reviewed changes
JohannesMessner
JohannesMessner reviewed Oct 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@JohannesMessner JohannesMessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this we should also bump our qdrant-client dependency to version 8, no? It doesn't look like this preserves compatability with v7, but maybe I wrong

@alaeddine-13 alaeddine-13 changed the title fix: support qdrant on docarray fix: support qdrant 0.8 Oct 17, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2022 •
edited
Loading

Codecov Report

Merging #635 (ae51a87) into main (125eb3a) will decrease coverage by 0.08%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   85.02%   84.94%   -0.09%     
==========================================
  Files         133      133              
  Lines        6718     6735      +17     
==========================================
+ Hits         5712     5721       +9     
- Misses       1006     1014       +8
Flag Coverage Δ
docarray 84.94% <83.33%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/qdrant/backend.py 95.14% <83.33%> (-0.90%) ⬇️
docarray/array/storage/redis/find.py 86.36% <0.00%> (-7.76%) ⬇️
docarray/array/mixins/sample.py 84.61% <0.00%> (-7.70%) ⬇️
docarray/array/mixins/evaluation.py 84.12% <0.00%> (-4.77%) ⬇️
docarray/array/storage/base/helper.py 89.74% <0.00%> (-2.57%) ⬇️
docarray/array/queryset/lookup.py 76.08% <0.00%> (-2.18%) ⬇️
docarray/array/storage/memory/getsetdel.py 96.07% <0.00%> (-1.97%) ⬇️
docarray/array/mixins/find.py 87.62% <0.00%> (-1.04%) ⬇️
docarray/array/mixins/io/pushpull.py 91.80% <0.00%> (-0.64%) ⬇️
docarray/array/storage/sqlite/backend.py 93.58% <0.00%> (-0.09%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dongxiang123 dongxiang123 force-pushed the fix-qdrant-support-docarray branch from ae86cb1 to b2c8986 Compare October 17, 2022 09:45
JoanFM
JoanFM requested changes Oct 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check there is another docker compose to change

@dongxiang123 dongxiang123 force-pushed the fix-qdrant-support-docarray branch from b2c8986 to 95f434c Compare October 17, 2022 10:08
@dongxiang123
Copy link
Copy Markdown
Contributor Author

dongxiang123 commented Oct 17, 2022

check there is another docker compose to change

Yes, that is right.

@dongxiang123 dongxiang123 force-pushed the fix-qdrant-support-docarray branch 2 times, most recently from 04f92e7 to 3531943 Compare October 18, 2022 06:57
@dongxiang123 dongxiang123 force-pushed the fix-qdrant-support-docarray branch from 3531943 to 5955540 Compare October 18, 2022 08:24
JoanFM
JoanFM requested changes Oct 18, 2022
View reviewed changes
@dongxiang123 dongxiang123 force-pushed the fix-qdrant-support-docarray branch 2 times, most recently from dcd9993 to af02d14 Compare October 18, 2022 11:31
@dongxiang123 dongxiang123 force-pushed the fix-qdrant-support-docarray branch 3 times, most recently from bd65536 to 1851fd6 Compare October 19, 2022 07:54
@dongxiang123 dongxiang123 force-pushed the fix-qdrant-support-docarray branch from a6f9076 to c10449c Compare October 19, 2022 08:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 19, 2022

📝 Docs are deployed on https://ft-fix-qdrant-support-docarray--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 5dbf1a3 into main Oct 19, 2022
@JoanFM JoanFM deleted the fix-qdrant-support-docarray branch October 19, 2022 12:18
@alaeddine-13 alaeddine-13 mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaeddine-13 alaeddine-13 alaeddine-13 left review comments

@JohannesMessner JohannesMessner JohannesMessner left review comments

@JoanFM JoanFM JoanFM approved these changes

Assignees

No one assigned

Labels

area/core area/docs area/setup area/testing component/array size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dongxiang123 @alaeddine-13 @JoanFM @JohannesMessner