Skip to content

feat: add filter support for qdrant document store#652

Merged
JoanFM merged 2 commits intomainfrom
add-support-for-filter-qdrant-database
Oct 24, 2022
Merged

feat: add filter support for qdrant document store#652
JoanFM merged 2 commits intomainfrom
add-support-for-filter-qdrant-database

Conversation

@dongxiang123
Copy link
Copy Markdown
Contributor

Goals:

  • Currently the Qdrant backend doesn't support filter, this PR is to support filter method in Qdrant from docarray
  • ...
  • check and update documentation, if required. See guide

@JoanFM JoanFM changed the title feat: add filter support for qdrant database. feat: add filter support for qdrant document store. Oct 20, 2022
@dongxiang123 dongxiang123 force-pushed the add-support-for-filter-qdrant-database branch from 7b8f4d3 to 5c8a7fa Compare October 20, 2022 07:03
@JoanFM
Copy link
Copy Markdown
Member

JoanFM commented Oct 20, 2022

@dongxiang123 please make sure to update this table.

https://docarray.jina.ai/advanced/document-store/#feature-summary

@dongxiang123 dongxiang123 requested a review from alexcg1 October 20, 2022 07:05
@dongxiang123 dongxiang123 force-pushed the add-support-for-filter-qdrant-database branch from 5c8a7fa to d0fa828 Compare October 20, 2022 07:09
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2022

Codecov Report

Merging #652 (383fc8a) into main (eccf771) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   86.46%   86.48%   +0.01%     
==========================================
  Files         133      133              
  Lines        6762     6771       +9     
==========================================
+ Hits         5847     5856       +9     
  Misses        915      915              
Flag Coverage Δ
docarray 86.48% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/qdrant/find.py 83.92% <100.00%> (+3.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dongxiang123
Copy link
Copy Markdown
Contributor Author

@dongxiang123 please make sure to update this table.

https://docarray.jina.ai/advanced/document-store/#feature-summary

Yes, good point, edited the summary.

@dongxiang123 dongxiang123 changed the title feat: add filter support for qdrant document store. feat: add filter support for qdrant document store Oct 20, 2022
@dongxiang123 dongxiang123 force-pushed the add-support-for-filter-qdrant-database branch from d0fa828 to 26592a3 Compare October 20, 2022 08:58
@alexcg1
Copy link
Copy Markdown
Contributor

alexcg1 commented Oct 20, 2022

@dongxiang123 you should tag @NicholasDunham , not me. He handles DocArray. I handle core

@alexcg1 alexcg1 removed their request for review October 20, 2022 08:58
@alexcg1 alexcg1 self-requested a review October 20, 2022 09:14
@dongxiang123 dongxiang123 force-pushed the add-support-for-filter-qdrant-database branch from 7e92efb to ce5f2f2 Compare October 20, 2022 09:32
Copy link
Copy Markdown
Contributor

@NicholasDunham NicholasDunham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@dongxiang123 dongxiang123 force-pushed the add-support-for-filter-qdrant-database branch 4 times, most recently from fe7d5c0 to ba7a326 Compare October 21, 2022 06:44
@dongxiang123 dongxiang123 force-pushed the add-support-for-filter-qdrant-database branch from ba7a326 to 15a06ed Compare October 21, 2022 12:25
@JoanFM JoanFM requested a review from NicholasDunham October 21, 2022 12:27
Copy link
Copy Markdown
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when @NicholasDunham approves, we can merge

@dongxiang123 dongxiang123 force-pushed the add-support-for-filter-qdrant-database branch from 8a95289 to fc7b55f Compare October 23, 2022 05:39
@github-actions
Copy link
Copy Markdown

@JoanFM JoanFM requested a review from NicholasDunham October 24, 2022 05:57
@JoanFM JoanFM dismissed alexcg1’s stale review October 24, 2022 06:56

nicholas approved

@JoanFM JoanFM merged commit 9a6a390 into main Oct 24, 2022
@JoanFM JoanFM deleted the add-support-for-filter-qdrant-database branch October 24, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants