Skip to content

feat: exception for all from generator calls on instance#659

Merged
JoanFM merged 5 commits intomainfrom
feat-exception-for-all-from-generator-calls-from-instance
Oct 21, 2022
Merged

feat: exception for all from generator calls on instance#659
JoanFM merged 5 commits intomainfrom
feat-exception-for-all-from-generator-calls-from-instance

Conversation

@anna-charlotte
Copy link
Copy Markdown
Contributor

Goals:

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2022

Codecov Report

Merging #659 (e52c7a6) into main (7183c8d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   86.46%   86.48%   +0.01%     
==========================================
  Files         133      133              
  Lines        6761     6762       +1     
==========================================
+ Hits         5846     5848       +2     
+ Misses        915      914       -1     
Flag Coverage Δ
docarray 86.48% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/io/from_gen.py 85.48% <100.00%> (+0.23%) ⬆️
docarray/array/storage/weaviate/find.py 84.81% <0.00%> (+1.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anna-charlotte
Copy link
Copy Markdown
Contributor Author

Next: Trying to generalize this for the from_xxx classmethods to avoid handling each one individually.

@anna-charlotte anna-charlotte force-pushed the feat-exception-for-all-from-generator-calls-from-instance branch from 6b233d3 to 84a2868 Compare October 21, 2022 09:18
@anna-charlotte anna-charlotte marked this pull request as ready for review October 21, 2022 11:44
@anna-charlotte anna-charlotte requested a review from JoanFM October 21, 2022 11:51
Copy link
Copy Markdown
Member

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoanFM JoanFM merged commit 191e671 into main Oct 21, 2022
@JoanFM JoanFM deleted the feat-exception-for-all-from-generator-calls-from-instance branch October 21, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: unintuitive behavior from all generator methods return a da but do not modify in place

3 participants