Skip to content

fix(array): move hubble url to inline #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxiao merged 2 commits into from
Jan 20, 2022
Merged

fix(array): move hubble url to inline #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3618a45
fix(array): move hubble url to inline
hanxiao Jan 20, 2022
7b3d501
fix(array): move hubble url to inline
hanxiao Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docarray/array/mixins/io/pushpull.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def _get_cloud_api() -> str:
class PushPullMixin:
"""Transmitting :class:`DocumentArray` via Jina Cloud Service"""

_service_url = _get_cloud_api() + '/v2/rpc/da.'
_max_bytes = 4 * 1024 * 1024 * 1024

def push(self, token: str, show_progress: bool = False) -> None:
Expand Down Expand Up @@ -86,7 +85,9 @@ def read(self, n=-1):

with progress as p_bar:
body = BufferReader(data, p_bar, task_id)
requests.post(self._service_url + 'push', data=body, headers=headers)
requests.post(
f'{_get_cloud_api()}/v2/rpc/da.push', data=body, headers=headers
)

@classmethod
def pull(
Expand All @@ -102,7 +103,7 @@ def pull(
"""
import requests

url = f'{cls._service_url}pull?token={token}'
url = f'{_get_cloud_api()}/v2/rpc/da.pull?token={token}'
response = requests.get(url)

progress = _get_progressbar(show_progress)
Expand Down