Conversation
Codecov Report
@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 88.10% 88.08% -0.02%
==========================================
Files 133 133
Lines 6538 6538
==========================================
- Hits 5760 5759 -1
- Misses 778 779 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
docarray/helper.py
Outdated
| hubble.logout() | ||
|
|
||
|
|
||
| def notebook_login(force: bool = False): |
There was a problem hiding this comment.
wait because hubble-sdk is working on a feature to autodetect it from notebook
NicholasDunham
left a comment
There was a problem hiding this comment.
Looks good overall; I made some minor wording changes. One usage note: login is a noun or adjective; log in is a verb.
Co-authored-by: Nicholas Dunham <[email protected]> Signed-off-by: AlaeddineAbdessalem <[email protected]>
thanks for the feedback, I applied your suggestions |
|
|
Co-authored-by: Johannes Messner <[email protected]> Signed-off-by: AlaeddineAbdessalem <[email protected]>
I changed it with the cloud emoji |
Co-authored-by: Nicholas Dunham <[email protected]> Signed-off-by: AlaeddineAbdessalem <[email protected]>
…feat-login-logout
|
📝 Docs are deployed on https://ft-feat-login-logout--jina-docs.netlify.app 🎉 |
Add login/logout methods in order to clarify login procedure while using docarray
closes: #696
should be merged after jina-ai/jina-hubble-sdk#96