feat: add 3d data handling of mesh vertices and faces#709
Conversation
Codecov Report
@@ Coverage Diff @@
## main #709 +/- ##
==========================================
+ Coverage 88.15% 88.20% +0.04%
==========================================
Files 134 134
Lines 6552 6578 +26
==========================================
+ Hits 5776 5802 +26
Misses 776 776
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alaeddine-13
left a comment
There was a problem hiding this comment.
we should add documentation here
https://docarray.jina.ai/datatypes/mesh/
docs/datatypes/mesh/index.md
Outdated
| :width: 50% | ||
| ``` | ||
|
|
||
| ## Mesh |
There was a problem hiding this comment.
the section title is 3D Mesh above, and then we explain point cloud and go back to mesh.
It feels a bit weird to me, maybe we should name this one Vertices and Faces representation and the other one point cloud representation ?
There was a problem hiding this comment.
True, and maybe also move the mesh representation (vertices and faces) up, so that first vertices and faces are introduced, and than point cloud, since the point cloud contains less information than the vertices-faces-representation. What do u think?
alaeddine-13
left a comment
There was a problem hiding this comment.
lgtm, let's wait for @NicholasDunham's feedback
samsja
left a comment
There was a problem hiding this comment.
lgtm to me as well. @JohannesMessner what do u think about the naming of the function ?
Co-authored-by: Nicholas Dunham <[email protected]> Signed-off-by: anna-charlotte <[email protected]>
|
📝 Docs are deployed on https://ft-feat-3d-data-handling-of-meshes-708--jina-docs.netlify.app 🎉 |
Goals:
load_uri_to_vertices_and_faces_chunk_tensors+ tests