Skip to content

feat: add docarray version to push#710

Merged
hanxiao merged 2 commits intomainfrom
feat-add-version-push
Oct 31, 2022
Merged

feat: add docarray version to push#710
hanxiao merged 2 commits intomainfrom
feat-add-version-push

Conversation

@hanxiao
Copy link
Copy Markdown
Member

@hanxiao hanxiao commented Oct 31, 2022

Signed-off-by: Han Xiao [email protected]

  • move docarray version info into metaData
  • remove unreachable warning code

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2022

Codecov Report

Merging #710 (23640d9) into main (8f93642) will decrease coverage by 3.83%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   88.50%   84.67%   -3.84%     
==========================================
  Files         133      133              
  Lines        6542     6538       -4     
==========================================
- Hits         5790     5536     -254     
- Misses        752     1002     +250     
Flag Coverage Δ
docarray 84.67% <100.00%> (-3.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/io/pushpull.py 93.10% <100.00%> (+0.60%) ⬆️
docarray/array/mixins/embed.py 9.89% <0.00%> (-82.42%) ⬇️
docarray/array/mixins/plot.py 28.13% <0.00%> (-39.83%) ⬇️
docarray/array/mixins/getattr.py 60.60% <0.00%> (-21.22%) ⬇️
docarray/array/queryset/parser.py 68.33% <0.00%> (-20.00%) ⬇️
docarray/array/mixins/group.py 71.05% <0.00%> (-18.43%) ⬇️
docarray/array/mixins/io/csv.py 71.05% <0.00%> (-18.43%) ⬇️
docarray/array/mixins/setitem.py 64.16% <0.00%> (-18.34%) ⬇️
docarray/array/mixins/delitem.py 75.55% <0.00%> (-13.34%) ⬇️
docarray/array/mixins/getitem.py 79.36% <0.00%> (-11.12%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hanxiao hanxiao marked this pull request as ready for review October 31, 2022 11:46
Copy link
Copy Markdown
Contributor

@mapleeit mapleeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanxiao hanxiao merged commit 3f07f52 into main Oct 31, 2022
@hanxiao hanxiao deleted the feat-add-version-push branch October 31, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants