Skip to content

fix(pydantic): turn on pydantic smart union #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxiao merged 3 commits into from
Jan 23, 2022
Merged

fix(pydantic): turn on pydantic smart union #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df3f45d
fix(pydantic): disable smart union
numb3r3 Jan 21, 2022
27fe344
fix: clean test case
numb3r3 Jan 21, 2022
359328c
fix(document): add smart union to pydantic document
hanxiao Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docarray/document/pydantic_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ def _blob2base64(cls, v):
else:
raise ValueError('must be bytes')

class Config:
smart_union = True


PydanticDocument.update_forward_refs()

Expand Down
8 changes: 7 additions & 1 deletion tests/unit/test_pydantic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,13 @@ def test_with_embedding_no_tensor():

@pytest.mark.parametrize(
'tag_value, tag_type',
[(3, float), (3.4, float), ('hello', str), (True, bool), (False, bool)],
[
(3.0, float),
('hello', str),
('1', str),
(True, bool),
(False, bool),
],
)
@pytest.mark.parametrize('protocol', ['protobuf', 'jsonschema'])
def test_tags_int_float_str_bool(tag_type, tag_value, protocol):
Expand Down