feat: add flag to disable list-like structure in DocArray#730
Conversation
f5d0536 to
8421596
Compare
Codecov ReportBase: 83.50% // Head: 36.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
===========================================
- Coverage 83.50% 36.53% -46.98%
===========================================
Files 133 133
Lines 6651 6703 +52
===========================================
- Hits 5554 2449 -3105
- Misses 1097 4254 +3157
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JoanFM
left a comment
There was a problem hiding this comment.
Please make sure to Document this behavior
a34c453 to
8c7bcb8
Compare
8c7bcb8 to
623b8ae
Compare
af1f0b4 to
0647cfb
Compare
faf1528 to
46297dc
Compare
21d8e69 to
207725f
Compare
alaeddine-13
left a comment
There was a problem hiding this comment.
Also methods that create the offset2id schema should be disabled if the flag is false
6730cdf to
85db92e
Compare
da36af1 to
23ff90f
Compare
36d1a31 to
f300d8b
Compare
1502b68 to
a028e01
Compare
9d6a9d0 to
2a04fa6
Compare
867f5ca to
6d668b7
Compare
|
📝 Docs are deployed on https://ft-feat-add-flag-to-disable-offset2id--jina-docs.netlify.app 🎉 |
6d668b7 to
a09ef37
Compare
|
📝 Docs are deployed on https://ft-feat-add-flag-to-disable-offset2id--jina-docs.netlify.app 🎉 |
Goals:
This information is only updated/synced when a DA is destroyed or quit the context manager. Furthermore, offset2id is updated in memory in all update operations.
However, offset2id is not useful in indexers where concurrent usage is possible and users do not need information about document location. Besides, updating offset2id is not efficient.
Therefore, it's important to have an option that disables list-like behavior (and offset2id with it) and use it in DocumentArray indexers.