fix: add num_worker argument to embed_and_evalute and pass label_tag#731
Merged
JoanFM merged 8 commits intodocarray:mainfrom Nov 9, 2022
Merged
Conversation
Codecov ReportBase: 87.85% // Head: 54.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
===========================================
- Coverage 87.85% 54.94% -32.92%
===========================================
Files 133 133
Lines 6614 6614
===========================================
- Hits 5811 3634 -2177
- Misses 803 2980 +2177
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…:guenthermi/docarray into fix-missing-kwargs-in-embed_and_evaluate
JoanFM
approved these changes
Nov 9, 2022
JoanFM
requested changes
Nov 9, 2022
Member
JoanFM
left a comment
There was a problem hiding this comment.
For the label tag, it seems there should be a test covering it
JoanFM
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
num_workerattribute in theembed_and_evaluatefunction for the matching steplabel_tagto the execution ofevaluatein theembed_and_evaluatefunction