Conversation
Signed-off-by: AnneY <[email protected]>
Signed-off-by: AnneY <[email protected]>
924906a to
9e3f155
Compare
Signed-off-by: AnneY <[email protected]>
Codecov ReportBase: 87.54% // Head: 84.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
- Coverage 87.54% 84.39% -3.16%
==========================================
Files 133 133
Lines 6649 6651 +2
==========================================
- Hits 5821 5613 -208
- Misses 828 1038 +210
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JoanFM
requested changes
Nov 10, 2022
tests/unit/array/mixins/test_find.py
Outdated
|
|
||
| results = da.find('pizza', filter=filter) | ||
|
|
||
| assert all([int(r.id) < 10 for r in results]) == True |
Member
There was a problem hiding this comment.
first u need to assrt length of results is larger than 0, otherwise I think the next asserts would still work
tests/unit/array/mixins/test_find.py
Outdated
| results = da.find('pizza', filter=filter) | ||
|
|
||
| assert all([int(r.id) < 10 for r in results]) == True | ||
| assert all([r.tags['i'] < 10 for r in results]) == True |
JoanFM
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to #738
Goals: