ci: impose jina dependencies at the end of CI CD environment setup#747
Merged
alaeddine-13 merged 1 commit intomainfrom Nov 10, 2022
Merged
ci: impose jina dependencies at the end of CI CD environment setup#747alaeddine-13 merged 1 commit intomainfrom
alaeddine-13 merged 1 commit intomainfrom
Conversation
JohannesMessner
approved these changes
Nov 10, 2022
samsja
approved these changes
Nov 10, 2022
JoanFM
approved these changes
Nov 10, 2022
Codecov ReportBase: 87.58% // Head: 83.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 87.58% 83.57% -4.02%
==========================================
Files 133 133
Lines 6703 6703
==========================================
- Hits 5871 5602 -269
- Misses 832 1101 +269
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #726 we update qdrant version and as qdrant imposes grpcio 1.50.0 which is incompatible with Jina, we make sure to install docarray[full] at the end to respect the jina grpcio version restriction.
However, as we split out tests into proto and old proto tests we didn't respect this.
This PR fixes the order of installation.