Skip to content

feat: add rgbd representation of 3d mesh#753

Merged
samsja merged 27 commits intomainfrom
feat-add-rgbd-representation-751
Nov 17, 2022
Merged

feat: add rgbd representation of 3d mesh#753
samsja merged 27 commits intomainfrom
feat-add-rgbd-representation-751

Conversation

@anna-charlotte
Copy link
Copy Markdown
Contributor

@anna-charlotte anna-charlotte commented Nov 11, 2022

Goals:

A common input format of 3d data for machine learning model are RGBD images due to the fixed size ndarray representation. RGB-D images are usually stored in 2 separate image files, the first one stores the RGB values (shape=(n, m, 3)), the second one stores a depth value for each pixel of the RGB image (shape=(n, m, 1)). Those two ndarray can be concatenated to one ndarray of shape=(n, m, 4).

Representation in DocArray:

  • Save the two file paths in the .uri attribute of a Documents .chunks

  • Load the 2 files into 1 tensor and store the tensor of shape=(n, m, 4) in the Document's top level .tensor attribute.

  • load chunks uris to top level rgbd image tensor

  • add .display() function for rgbd image tensor

  • check and update documentation, if required. See guide

@anna-charlotte anna-charlotte self-assigned this Nov 11, 2022
@anna-charlotte anna-charlotte linked an issue Nov 11, 2022 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 11, 2022

Codecov Report

Base: 88.13% // Head: 87.90% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (7da86f2) compared to base (97374ec).
Patch coverage: 40.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   88.13%   87.90%   -0.23%     
==========================================
  Files         133      133              
  Lines        6703     6741      +38     
==========================================
+ Hits         5908     5926      +18     
- Misses        795      815      +20     
Flag Coverage Δ
docarray 87.90% <40.62%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/document/mixins/plot.py 66.36% <27.45%> (-4.34%) ⬇️
docarray/document/mixins/mesh.py 98.27% <92.30%> (-1.73%) ⬇️
docarray/array/mixins/plot.py 67.09% <0.00%> (-0.87%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

anna-charlotte and others added 3 commits November 15, 2022 13:45
Co-authored-by: Alex Cureton-Griffiths <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Co-authored-by: Alex Cureton-Griffiths <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
@JoanFM JoanFM requested review from alexcg1 and samsja November 15, 2022 13:13
Copy link
Copy Markdown
Member

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@alexcg1 alexcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samsja samsja closed this Nov 15, 2022
@samsja samsja reopened this Nov 15, 2022
@anna-charlotte anna-charlotte force-pushed the feat-add-rgbd-representation-751 branch from 1c76b10 to 7b609fc Compare November 15, 2022 14:31
@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-add-rgbd-representation-751--jina-docs.netlify.app 🎉

1 similar comment
@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-add-rgbd-representation-751--jina-docs.netlify.app 🎉

Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-add-rgbd-representation-751--jina-docs.netlify.app 🎉

@anna-charlotte anna-charlotte force-pushed the feat-add-rgbd-representation-751 branch from f6b9bc8 to 7da86f2 Compare November 16, 2022 07:05
@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-add-rgbd-representation-751--jina-docs.netlify.app 🎉

@samsja samsja merged commit 227b2e5 into main Nov 17, 2022
@samsja samsja deleted the feat-add-rgbd-representation-751 branch November 17, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RGBD representation for 3d mesh

4 participants