Conversation
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 82.98% 83.65% +0.67%
==========================================
Files 87 92 +5
Lines 3814 4105 +291
==========================================
+ Hits 3165 3434 +269
- Misses 649 671 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
24e412b to
16ee772
Compare
numb3r3
suggested changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better keep track of the TODO items, I have compiled the TODOs from the code into the following summary:
da[1, ['text', 'id']])AllMixin_set_doc_value_pairs; add test coveragevectorIndexConfigis disabled to allow docs with no embeddings to be added. But this needs to change as it also disables vector search functionality. Will stay tuned and address this in the next step.This PR incorporated some previous changes from @alaeddine-13 on test setup and also some initial suggestions from @numb3r3. Thanks for the feedback.