Skip to content

feat: advanced pq indexer#87

Merged
hanxiao merged 24 commits intomainfrom
feat-pqs
Feb 2, 2022
Merged

feat: advanced pq indexer#87
hanxiao merged 24 commits intomainfrom
feat-pqs

Conversation

@numb3r3
Copy link
Copy Markdown
Contributor

@numb3r3 numb3r3 commented Jan 28, 2022

requires pqlite >= v0.2.1

$ pip install --upgrade pqlite>=0.2.1

Note: the unittest tests/unit/array/test_pqlite_indexing.py is an temp file only for ease debugging, and will then be merged into test_advance_indexing.py:

  • Done in commit @davidbp test: merge pqlite indexing with advance ind

TODO:

  • how to work with embedding=None

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2022

Codecov Report

Merging #87 (7485424) into main (3c4ba0b) will increase coverage by 0.48%.
The diff coverage is 89.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   84.18%   84.66%   +0.48%     
==========================================
  Files          93       99       +6     
  Lines        4147     4376     +229     
==========================================
+ Hits         3491     3705     +214     
- Misses        656      671      +15     
Flag Coverage Δ
docarray 84.66% <89.95%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/pqlite/seqlike.py 75.00% <75.00%> (ø)
docarray/array/pqlite.py 80.00% <80.00%> (ø)
docarray/array/storage/pqlite/helper.py 90.27% <90.27%> (ø)
docarray/array/storage/pqlite/backend.py 96.77% <96.77%> (ø)
docarray/array/storage/pqlite/getsetdel.py 96.82% <96.82%> (ø)
docarray/array/document.py 83.33% <100.00%> (+1.85%) ⬆️
docarray/array/storage/pqlite/__init__.py 100.00% <100.00%> (ø)
docarray/array/mixins/plot.py 62.50% <0.00%> (+1.08%) ⬆️
docarray/helper.py 67.28% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4ba0b...7485424. Read the comment docs.

Copy link
Copy Markdown
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait until #81 is done

@CatStark CatStark removed the size/l label Feb 1, 2022
@github-actions github-actions bot added the size/l label Feb 1, 2022
@github-actions github-actions bot added size/m and removed size/l labels Feb 2, 2022
@hanxiao hanxiao merged commit 2a80abf into main Feb 2, 2022
@hanxiao hanxiao deleted the feat-pqs branch February 2, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants