feat: store distance scores in scores dict#873
Merged
JohannesMessner merged 6 commits intomainfrom Nov 30, 2022
Merged
Conversation
added 2 commits
November 29, 2022 11:34
Signed-off-by: anna-charlotte <[email protected]>
Codecov ReportBase: 86.36% // Head: 86.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
+ Coverage 86.36% 86.38% +0.01%
==========================================
Files 138 138
Lines 7116 7122 +6
==========================================
+ Hits 6146 6152 +6
Misses 970 970
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
JohannesMessner
requested changes
Nov 29, 2022
Signed-off-by: anna-charlotte <[email protected]>
3ac06fe to
50fe8e0
Compare
JohannesMessner
requested changes
Nov 30, 2022
Signed-off-by: anna-charlotte <[email protected]>
JohannesMessner
approved these changes
Nov 30, 2022
|
📝 Docs are deployed on https://ft-feat-milvus-store-scores-in-find--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anna-charlotte [email protected]
Goals:
Milvus: Store distance scores in a
Document's.scoresdictionary, under the key'score'to enable accessing those scores..scoresdict withkey = 'score'