Skip to content

ci: fix the wrong error msg #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsja merged 11 commits into from
Dec 1, 2022
Merged

ci: fix the wrong error msg #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b5f14bc
ci: fix the wrong error msg
nan-wang Dec 1, 2022
0dc5387
ci: add debugging
nan-wang Dec 1, 2022
37bf896
ci: fix the gramma
nan-wang Dec 1, 2022
793ecac
ci: fix the gramma
nan-wang Dec 1, 2022
cf3f113
ci: fix the gramma
nan-wang Dec 1, 2022
bbd741f
chore: clean up readme
nan-wang Dec 1, 2022
bd2efcd
ci: fix the gramma
nan-wang Dec 1, 2022
3f2a548
ci: fix the gramma
nan-wang Dec 1, 2022
73c8ea7
chore: clean up readme
nan-wang Dec 1, 2022
c8fa587
chore: clean up readme
nan-wang Dec 1, 2022
fae6085
ci: remove the debugging lines
nan-wang Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ jobs:

check-readme-modification:
runs-on: ubuntu-latest
outputs:
readme_changed: ${{ steps.step_output.outputs.readme_changed }}
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -159,16 +161,13 @@ jobs:
README.md

- name: Check if README is modified
id: step_output
if: steps.changed-files-specific.outputs.any_changed == 'true'
run: |
echo "README.md is modified"
touch SUCCESS

- name: Return outputs
run: |
[[ -f SUCCESS ]]
echo "readme_changed=true" >> $GITHUB_OUTPUT

publish-docarray-org:
needs: check-readme-modification
if: needs.check-readme-modification.outputs.readme_changed == 'true'
uses: ./.github/workflows/publish-docarray-org.yml
secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/publish-docarray-org.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Check trigger event
run: |
touch SUCCESS
if: github.event_name == 'pull_request'
if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }}
- name: Fail release token
run: |
[[ -f SUCCESS ]]
Expand Down
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ Let's use DocArray and the [Totally Looks Like](https://sites.google.com/view/to
</thead>
<tbody>
<tr align="center">
<td><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/left-00018.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
<td><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/right-00018.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
<td><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/left-00131.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
<td><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/right-00131.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
<td><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/left-00018.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
<td><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/right-00018.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
<td><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/left-00131.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
<td><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/right-00131.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
</tr>
</tbody>
</table>
Expand Down Expand Up @@ -206,7 +206,7 @@ left_da.plot_image_sprites()
```

<p align="center">
<a href="https://docarray.jina.ai"><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/sprite.png?raw=true" alt="Load totally looks like dataset with docarray API" width="60%"></a>
<a href="https://docarray.jina.ai"><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/sprite.png?raw=true" alt="Load totally looks like dataset with docarray API" width="60%"></a>
</p>

### Apply preprocessing
Expand Down Expand Up @@ -252,7 +252,7 @@ left_da.plot_embeddings(image_sprites=True)
```

<p align="center">
<a href="https://docarray.jina.ai"><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/tsne.gif?raw=true" alt="Visualizing embedding via tSNE and embedding projector" width="90%"></a>
<a href="https://docarray.jina.ai"><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/tsne.gif?raw=true" alt="Visualizing embedding via tSNE and embedding projector" width="90%"></a>
</p>

Fun is fun, but recall our goal is to match left images against right images and so far we have only handled the left. Let's repeat the same procedure for the right:
Expand Down