Merged
Conversation
Signed-off-by: Johannes Messner <[email protected]>
Signed-off-by: Johannes Messner <[email protected]>
Codecov ReportBase: 88.13% // Head: 88.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
==========================================
- Coverage 88.13% 88.09% -0.04%
==========================================
Files 138 138
Lines 7137 7148 +11
==========================================
+ Hits 6290 6297 +7
- Misses 847 851 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Johannes Messner <[email protected]>
|
📝 Docs are deployed on https://ft-fix-milvus-len--jina-docs.netlify.app 🎉 |
samsja
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement len (somewhat) natively for milvus, not retlying on offset2id.
Milvus has no real native way to get the number of entities in a collection, so we have to send a full-on general filter query with an expression that always evaluates to true, and then count the returns. Therefore this is only done if list-like is turned off.