Skip to content

chore: finish storage document array todos#90

Merged
hanxiao merged 25 commits intomainfrom
da-todos
Feb 2, 2022
Merged

chore: finish storage document array todos#90
hanxiao merged 25 commits intomainfrom
da-todos

Conversation

@alaeddine-13
Copy link
Copy Markdown
Member

@alaeddine-13 alaeddine-13 commented Feb 1, 2022 •
edited
Loading

  • cover weaviate in test_embed (and possibly other mixin tests)
  • DocumentArraySqlite to become pickable
  • comments in __setitem__
  • TODOs in the code base
  • summary for storage backends

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #90 (b80d2f3) into main (3c4ba0b) will increase coverage by 0.48%.
The diff coverage is 89.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   84.18%   84.67%   +0.48%     
==========================================
  Files          93       92       -1     
  Lines        4147     4162      +15     
==========================================
+ Hits         3491     3524      +33     
+ Misses        656      638      -18
Flag Coverage Δ
docarray 84.67% <89.15%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/weaviate/seqlike.py 94.28% <ø> (+2.85%) ⬆️
docarray/array/mixins/setitem.py 81.81% <66.66%> (+0.50%) ⬆️
docarray/array/storage/memory/backend.py 95.65% <75.00%> (-1.97%) ⬇️
docarray/array/storage/base/backend.py 80.00% <83.33%> (+5.00%) ⬆️
docarray/array/storage/sqlite/backend.py 91.25% <94.73%> (+3.75%) ⬆️
docarray/array/storage/weaviate/backend.py 87.27% <95.00%> (+2.42%) ⬆️
docarray/array/mixins/plot.py 61.82% <100.00%> (+0.41%) ⬆️
docarray/array/storage/sqlite/__init__.py 100.00% <100.00%> (ø)
docarray/array/storage/sqlite/seqlike.py 94.64% <100.00%> (-1.79%) ⬇️
docarray/array/storage/weaviate/getsetdel.py 100.00% <100.00%> (+20.00%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4ba0b...b80d2f3. Read the comment docs.

@github-actions github-actions bot added size/m and removed size/s labels Feb 1, 2022
@github-actions github-actions bot added size/s and removed size/m labels Feb 1, 2022
@github-actions github-actions bot added size/m and removed size/s labels Feb 1, 2022
@CatStark CatStark removed the size/m label Feb 1, 2022
@github-actions github-actions bot added the size/m label Feb 1, 2022
@github-actions github-actions bot added size/l and removed size/m labels Feb 2, 2022
@alaeddine-13 alaeddine-13 marked this pull request as ready for review February 2, 2022 17:17
@hanxiao hanxiao merged commit 9ba25f8 into main Feb 2, 2022
@hanxiao hanxiao deleted the da-todos branch February 2, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanxiao hanxiao hanxiao approved these changes

Assignees

No one assigned

Labels

area/core area/testing component/array size/l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alaeddine-13 @hanxiao @CatStark