fix: backwards compatibility for _is_subindex#903
Merged
JohannesMessner merged 1 commit intomainfrom Dec 8, 2022
Merged
Conversation
Signed-off-by: AnneY <[email protected]>
guenthermi
reviewed
Dec 7, 2022
Contributor
guenthermi
left a comment
There was a problem hiding this comment.
Solved my problem. Thank you!
guenthermi
approved these changes
Dec 7, 2022
Codecov ReportBase: 88.06% // Head: 84.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
- Coverage 88.06% 84.44% -3.63%
==========================================
Files 138 138
Lines 7154 7154
==========================================
- Hits 6300 6041 -259
- Misses 854 1113 +259
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JohannesMessner
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AnneY [email protected]
Goals:
Serialized DocumentArray from old version may not have the attribute
_is_subindexset. This PR enable backwards compatibility for_is_subindex.