Skip to content

fix: add multiple connections to milvus#904

Merged
JohannesMessner merged 1 commit intomainfrom
fix-milvus-connections
Dec 8, 2022
Merged

fix: add multiple connections to milvus#904
JohannesMessner merged 1 commit intomainfrom
fix-milvus-connections

Conversation

@anna-charlotte
Copy link
Copy Markdown
Contributor

@anna-charlotte anna-charlotte commented Dec 7, 2022

Signed-off-by: anna-charlotte [email protected]

Goals:

Create a new connection everytime _init_storage() is called from Milvus Document Storage.

  • check and update documentation, if required. See guide

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 7, 2022

Codecov Report

Base: 87.78% // Head: 88.06% // Increases project coverage by +0.27% 🎉

Coverage data is based on head (041e268) compared to base (07cb522).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   87.78%   88.06%   +0.27%     
==========================================
  Files         138      138              
  Lines        7154     7154              
==========================================
+ Hits         6280     6300      +20     
+ Misses        874      854      -20     
Flag Coverage Δ
docarray 88.06% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/milvus/backend.py 98.22% <100.00%> (+1.77%) ⬆️
docarray/array/mixins/plot.py 67.96% <0.00%> (+0.86%) ⬆️
docarray/array/storage/elastic/backend.py 97.05% <0.00%> (+1.47%) ⬆️
docarray/array/storage/qdrant/backend.py 95.23% <0.00%> (+1.58%) ⬆️
docarray/array/storage/redis/backend.py 97.50% <0.00%> (+1.66%) ⬆️
docarray/array/storage/weaviate/backend.py 90.44% <0.00%> (+1.91%) ⬆️
docarray/array/storage/memory/backend.py 100.00% <0.00%> (+2.50%) ⬆️
docarray/array/storage/annlite/backend.py 97.43% <0.00%> (+2.56%) ⬆️
docarray/array/storage/sqlite/backend.py 95.06% <0.00%> (+3.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JohannesMessner JohannesMessner marked this pull request as ready for review December 8, 2022 10:11
@JohannesMessner JohannesMessner merged commit d9e5b26 into main Dec 8, 2022
@JohannesMessner JohannesMessner deleted the fix-milvus-connections branch December 8, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants