Conversation
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 85.13% 85.24% +0.11%
==========================================
Files 98 98
Lines 4392 4386 -6
==========================================
Hits 3739 3739
+ Misses 653 647 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hanxiao
requested changes
Feb 3, 2022
Member
hanxiao
left a comment
There was a problem hiding this comment.
only DocumentArray class method need to be extended. not Documet class method
Contributor
Author
Ok, reverted |
hanxiao
reviewed
Feb 3, 2022
hanxiao
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows
.emptyto work with storage backends that need "configuration information".Consider the following setting
A user can do
but can't do
Because the information from
configis ignored with.emptyis called.With this PR users can do