fix: query operator $exists does not work correctly with tags (#911)#923
Merged
JoanFM merged 3 commits intodocarray:mainfrom Dec 12, 2022
Merged
fix: query operator $exists does not work correctly with tags (#911)#923JoanFM merged 3 commits intodocarray:mainfrom
JoanFM merged 3 commits intodocarray:mainfrom
Conversation
Codecov ReportBase: 88.06% // Head: 83.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
- Coverage 88.06% 83.96% -4.11%
==========================================
Files 138 149 +11
Lines 7154 7675 +521
==========================================
+ Hits 6300 6444 +144
- Misses 854 1231 +377
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JohannesMessner
requested changes
Dec 9, 2022
Member
JohannesMessner
left a comment
There was a problem hiding this comment.
Looks good! just some minor tweaks to the documentation wording.
Signed-off-by: marcosbodio <[email protected]>
d1d8dfd to
906405b
Compare
Signed-off-by: Johannes Messner <[email protected]>
JohannesMessner
approved these changes
Dec 12, 2022
Signed-off-by: Johannes Messner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #911.
$existsoperator when applied to fields intags:{'tags__x': {'$exists': True}}returnsTruewhentags.x is not None