Conversation
Signed-off-by: Alex C-G <[email protected]>
Signed-off-by: Alex C-G <[email protected]>
Codecov ReportBase: 88.47% // Head: 85.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #934 +/- ##
==========================================
- Coverage 88.47% 85.07% -3.40%
==========================================
Files 155 155
Lines 8009 8009
==========================================
- Hits 7086 6814 -272
- Misses 923 1195 +272
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
@samsja or @JohannesMessner can someone approve and merge? |
JoanFM
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anyone got any objections to me changing "Multimodal Data" to "Data Types"?
Rationale: Most people working with DocArray are just working with one data type (as reflected in Google Analytics page/user views). Also we have "Multi-modal" under "Multimodal data" which seems odd.
I know we want to blow the multimodal trumpet, but I think it'd be good to get users building with DocArray for their single-data-types first then converting them to the cause.