-
Notifications
You must be signed in to change notification settings - Fork 238
chore: add different python version to ci #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
74e8e62
chore: add different python version to i
samsja 89302ec
chore: update cd as well
samsja 3a91bf5
fix: remove 3.11 for now
samsja 62b9a30
fix: add back 3.10
samsja 822fde8
fix: add back 3.11
samsja 3bc9bd7
feat: apply aleaddine suggestion
samsja a89a2ad
fix: string stuff
samsja 4e50645
Merge branch 'chore-updage-cicd' of github.com:docarray/docarray into…
samsja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: [3.7] | ||
| python-version: [3.8] | ||
| test-path: ${{fromJson(needs.prep-testbed.outputs.matrix)}} | ||
| steps: | ||
| - uses: actions/[email protected] | ||
|
|
@@ -69,7 +69,7 @@ jobs: | |
| files: "coverage.xml" | ||
| - name: Upload coverage from test to Codecov | ||
| uses: codecov/[email protected] | ||
| if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.7' | ||
| if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.8' | ||
| with: | ||
| file: coverage.xml | ||
| flags: ${{ steps.test.outputs.codecov_flag }} | ||
|
|
@@ -82,7 +82,7 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: [3.7] | ||
| python-version: [3.8] | ||
| test-path: ${{fromJson(needs.prep-testbed.outputs.matrix-oldproto)}} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
@@ -120,7 +120,7 @@ jobs: | |
| files: "coverage.xml" | ||
| - name: Upload coverage from test to Codecov | ||
| uses: codecov/codecov-action@v2 | ||
| if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.7' | ||
| if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.8' | ||
| with: | ||
| file: coverage.xml | ||
| flags: ${{ steps.test.outputs.codecov_flag }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,10 +52,10 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| - name: Set up Python 3.7 | ||
| - name: Set up Python 3.8 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: 3.7 | ||
| python-version: 3.8 | ||
| - name: Lint with flake8 | ||
| run: | | ||
| pip install flake8 | ||
|
|
@@ -70,10 +70,10 @@ jobs: | |
| - uses: actions/[email protected] | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Set up Python 3.7 | ||
| - name: Set up Python 3.8 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: 3.7 | ||
| python-version: 3.8 | ||
| - id: file_changes | ||
| uses: Ana06/[email protected] | ||
| - name: check black | ||
|
|
@@ -89,11 +89,11 @@ jobs: | |
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| - name: Set up Python 3.7 | ||
| - name: Set up Python 3.8 | ||
| uses: actions/setup-python@v4 | ||
| if: ${{ !github.event.pull_request.head.repo.fork }} | ||
| with: | ||
| python-version: 3.7 | ||
| python-version: 3.8 | ||
| - name: Styling | ||
| id: styling | ||
| if: ${{ !github.event.pull_request.head.repo.fork }} | ||
|
|
@@ -124,12 +124,15 @@ jobs: | |
|
|
||
| import-test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-env: ['3.8', '3.9', '3.10', '3.11'] | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| - name: Set up Python 3.7 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: 3.7 | ||
| python-version: ${{ matrix.python-env }} | ||
| - name: Prepare enviroment | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
|
|
@@ -160,7 +163,7 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: [3.7] | ||
| python-version: [3.8] | ||
| test-path: ${{fromJson(needs.prep-testbed.outputs.matrix)}} | ||
| steps: | ||
| - uses: actions/[email protected] | ||
|
|
@@ -197,7 +200,7 @@ jobs: | |
| files: "coverage.xml" | ||
| - name: Upload coverage from test to Codecov | ||
| uses: codecov/[email protected] | ||
| if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.7' | ||
| if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.8' | ||
| with: | ||
| file: coverage.xml | ||
| flags: ${{ steps.test.outputs.codecov_flag }} | ||
|
|
@@ -210,7 +213,7 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: [3.7] | ||
| python-version: [3.8] | ||
| test-path: ${{fromJson(needs.prep-testbed.outputs.matrix-oldproto)}} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
@@ -248,7 +251,7 @@ jobs: | |
| files: "coverage.xml" | ||
| - name: Upload coverage from test to Codecov | ||
| uses: codecov/codecov-action@v2 | ||
| if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.7' | ||
| if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.8' | ||
| with: | ||
| file: coverage.xml | ||
| flags: ${{ steps.test.outputs.codecov_flag }} | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.