Skip to content

fix: remove offset index create on list like false elasticsearch#936

Merged
JoanFM merged 1 commit intodocarray:mainfrom
alphinside:fix-elastic-remove-offset-index-creation-on-non-list-like
Dec 14, 2022
Merged

fix: remove offset index create on list like false elasticsearch#936
JoanFM merged 1 commit intodocarray:mainfrom
alphinside:fix-elastic-remove-offset-index-creation-on-non-list-like

Conversation

@alphinside
Copy link
Copy Markdown
Contributor

Currently, when list_like is set to False, list-like operation is disabled but the offset2id elastic index still being created

Goals:

  • handle offset2id index creation when list_like set to false
  • ...
  • check and update documentation, if required. See guide

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 13, 2022

Codecov Report

Base: 85.14% // Head: 81.03% // Decreases project coverage by -4.11% ⚠️

Coverage data is based on head (08a10b4) compared to base (a5a6778).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   85.14%   81.03%   -4.12%     
==========================================
  Files         155      155              
  Lines        8018     8018              
==========================================
- Hits         6827     6497     -330     
- Misses       1191     1521     +330     
Flag Coverage Δ
docarray 81.03% <100.00%> (-4.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/elastic/backend.py 93.38% <100.00%> (-3.68%) ⬇️
docarray/array/mixins/reduce.py 26.92% <0.00%> (-73.08%) ⬇️
docarray/array/mixins/io/pushpull.py 23.07% <0.00%> (-70.09%) ⬇️
docarray/array/mixins/io/csv.py 23.68% <0.00%> (-65.79%) ⬇️
docarray/array/mixins/io/dataframe.py 41.66% <0.00%> (-58.34%) ⬇️
docarray/array/mixins/sample.py 45.45% <0.00%> (-54.55%) ⬇️
docarray/array/mixins/io/common.py 26.31% <0.00%> (-42.11%) ⬇️
docarray/array/mixins/plot.py 28.13% <0.00%> (-39.83%) ⬇️
docarray/array/mixins/group.py 44.73% <0.00%> (-26.32%) ⬇️
docarray/array/mixins/io/json.py 68.75% <0.00%> (-25.00%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alphinside alphinside force-pushed the fix-elastic-remove-offset-index-creation-on-non-list-like branch from 84c1a89 to 08a10b4 Compare December 14, 2022 01:22
@JoanFM JoanFM merged commit 6bbcde8 into docarray:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants