Skip to content

fix: unwanted coercion in to_pydantic_model #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 7 commits into from
Dec 17, 2022
Merged

fix: unwanted coercion in to_pydantic_model #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d2bfe24
feat: native len for milvus
JohannesMessner Dec 2, 2022
e8422c8
fix: make implementing len non-optional
JohannesMessner Dec 2, 2022
69c471c
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Dec 5, 2022
c1643d0
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Dec 13, 2022
a0c1dd2
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Dec 15, 2022
814cf69
fix: raise pydantic version to fix to_dict bug
JohannesMessner Dec 15, 2022
0e5e677
test: add test
JohannesMessner Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
'matplotlib',
'Pillow',
'fastapi',
'pydantic>=1.9.0',
'uvicorn',
],
'full': [
Expand All @@ -63,6 +64,7 @@
'scipy',
'av',
'fastapi',
'pydantic>=1.9.0',
'uvicorn',
'strawberry-graphql',
],
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/test_pydantic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,22 @@ def test_tags_int_float_str_bool(tag_type, tag_value, protocol):
assert isinstance(dd, tag_type)


@pytest.mark.parametrize('protocol', ['protobuf', 'jsonschema'])
def test_infinity_no_coercion(protocol):
# Test for issue #948: https://github.com/docarray/docarray/issues/948
d = Document()
d.tags['title'] = 'Infinity'

d_pydantic = d.to_pydantic_model()
d_pydantic.tags['title'] = 'Infinity'

d_json = d.to_json(protocol=protocol)
assert '"title": "Infinity"' in d_json

d_dict = d.to_dict(protocol=protocol)
assert d_dict['tags']['title'] == 'Infinity'


@pytest.mark.parametrize(
'blob', [None, b'123', bytes(Document()), bytes(bytearray(os.urandom(512 * 4)))]
)
Expand Down