Skip to content

fix(store): change default serialization protocol to pickle #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxiao merged 2 commits into from
Feb 4, 2022
Merged

fix(store): change default serialization protocol to pickle #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d50728
fix(store): change default serialization protocol to pickle
hanxiao Feb 4, 2022
9f60014
docs(store): add documentation for storage backend
hanxiao Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docarray/array/storage/sqlite/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def _sanitize_table_name(table_name: str) -> str:
class SqliteConfig:
connection: Optional[Union[str, 'sqlite3.Connection']] = None
table_name: Optional[str] = None
serialize_config: Dict = field(default_factory=lambda: {'protocol': 'protobuf'})
serialize_config: Dict = field(default_factory=dict)
conn_config: Dict = field(default_factory=dict)
journal_mode: str = 'DELETE'
synchronous: str = 'OFF'
Expand Down
2 changes: 1 addition & 1 deletion docarray/array/storage/weaviate/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class WeaviateConfig:
client: Optional[Union[str, weaviate.Client]] = None
n_dim: Optional[int] = None
name: Optional[str] = None
serialize_config: Dict = field(default_factory=lambda: {'protocol': 'protobuf'})
serialize_config: Dict = field(default_factory=dict)


class BackendMixin(BaseBackendMixin):
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/array/mixins/test_embed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
)


@pytest.mark.parametrize('framework', ['onnx', 'keras', 'pytorch', 'paddle'])
@pytest.mark.parametrize('framework', ['onnx', 'keras', 'pytorch'])
@pytest.mark.parametrize(
'da', [DocumentArray, DocumentArraySqlite, DocumentArrayWeaviate]
)
Expand Down