Don't run bundle update in the Dockerfile#3770
Merged
mdlinville merged 1 commit intodocker:v17.03from Jul 3, 2017
mdlinville:v17.03
Merged
Don't run bundle update in the Dockerfile#3770mdlinville merged 1 commit intodocker:v17.03from mdlinville:v17.03
mdlinville merged 1 commit intodocker:v17.03from
mdlinville:v17.03
Conversation
This avoids the US-ASCII bug in jekyll-redirect plugin
thaJeztah
reviewed
Jul 1, 2017
Member
thaJeztah
left a comment
There was a problem hiding this comment.
one nit, but LGTM otherwise
| FROM starefossen/github-pages:137 | ||
|
|
||
| COPY . /usr/src/app/ | ||
| COPY . /usr/src/app |
Member
There was a problem hiding this comment.
Can you change this back, as it doesn't seem related to this change
Author
There was a problem hiding this comment.
It is related. One is what @johndmulhausen told me to use and the other one (without the /) is what is in the onbuild version of the github-pages plugin. Probably it doesn't matter but I thought maybe it was best to stick to how they had it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the US-ASCII bug in jekyll-redirect plugin