Skip to content

Add setter to auths if it's null to avoid NPE when getting auths#2142

Merged
eddumelendez merged 1 commit intodocker-java:mainfrom
chunweilim:fix-npe-when-auths-null
Jul 30, 2023
Merged

Add setter to auths if it's null to avoid NPE when getting auths#2142
eddumelendez merged 1 commit intodocker-java:mainfrom
chunweilim:fix-npe-when-auths-null

Conversation

@chunweilim
Copy link
Copy Markdown
Contributor

This is to resolve #2138 where NullPointerException is thrown if auths is null from config.json.

@chunweilim chunweilim requested a review from a team as a code owner July 13, 2023 15:03
@chunweilim
Copy link
Copy Markdown
Contributor Author

Hi @eddumelendez, could you review the PR and retrigger the build?

@chunweilim
Copy link
Copy Markdown
Contributor Author

Hi @eddumelendez, seems like the build step wasn't able to install containerd.io for docker-ce, though I'm not sure whether it's an intermittent issue or not as it seems to be passing for previous builds.

I have tested the build step by explicitly installing containerd.io before docker-ce. You can take a look at chunweilim#2.

Let me know if I should create a new PR for this or tag along this PR for the build step change.

@eddumelendez eddumelendez added this to the next milestone Jul 30, 2023
@eddumelendez eddumelendez merged commit e92c30e into docker-java:main Jul 30, 2023
@eddumelendez
Copy link
Copy Markdown
Member

Thanks for your contribution, @chunweilim !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

config.json file with auths null cause NPE

2 participants