This repository was archived by the owner on Dec 3, 2025. It is now read-only.
WIP Initial PowerShelll kernel prototype#751
Closed
TylerLeonhardt wants to merge 3 commits intodotnet:masterfrom
Closed
WIP Initial PowerShelll kernel prototype#751TylerLeonhardt wants to merge 3 commits intodotnet:masterfrom
TylerLeonhardt wants to merge 3 commits intodotnet:masterfrom
Conversation
jonsequitur
reviewed
Jan 15, 2020
Author
|
The "order matters" issue can be fixed by using a similar solution to what we did with Azure Functions. Dropping this file for future reference |
SteveL-MSFT
suggested changes
Jan 16, 2020
jonsequitur
reviewed
Jan 18, 2020
jonsequitur
reviewed
Jan 18, 2020
Author
|
Haven't addressed feedback yet but have addressed the "order matters" problem. See the example Notebook (in GitHub gists) to see the results of that work. It's using the same concept that Azure Functions to maintain order (a |
jonsequitur
reviewed
Jan 23, 2020
Microsoft.DotNet.Interactive.PowerShell/Commands/TracePipelineObjectCommand.cs
Show resolved
Hide resolved
jonsequitur
reviewed
Jan 23, 2020
jonsequitur
reviewed
Jan 23, 2020
| KernelInvocationContext context, | ||
| IKernelCommand command) | ||
| { | ||
| context.Publish( |
Contributor
There was a problem hiding this comment.
We added a KernelInvocationContext.DisplayAsync extension method that might simplify this for you.
jonsequitur
reviewed
Jan 23, 2020
7a3792d to
70a4e13
Compare
Author
|
Closing in favor of dotnet/interactive#9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles the 3 basic messages:
Things pending in this PR:
Example PowerShell notebook that came from this very change.