Open
Conversation
efantinatti
approved these changes
Dec 24, 2024
efantinatti
left a comment
There was a problem hiding this comment.
Dear Dean Hennessy
Session 1:
1 - OK.
Session 2:
2 - OK.
Session 3:
3 - Partial.
-- Cross Join - Q1: Missing CROSS JOIN.
-- DELETE - Q1: You query deletes everything not the oldest entry.
-- UPDATE - Q1: COALLESCE not taking effect. nullvalues are seen.
Final:
4 - Check the aforementioned points prior to merging your feature branch 'assignment-two' to 'main'.
Mark: 64 points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Draw a couple of ERD diagrams, write some sql code to answer the Qs in the assignment.
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I tried several approaches - especiallly on the cross join. It worked but I wasn't convinced it was correct.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Especially on the cross join and the last one on updating the table by adding current_quantity. I had to delete the table and start again a few times. Then the added column wasn't showing up. But no errors.
How were these changes tested?
In db browser for sqlite.
A reference to a related issue in your repository (if applicable)
N/A
Checklist
[x ] I can confirm that my changes are working as intended