Skip to content

Add support for SELECT TOP construct for mssql dialect for limit#41

Merged
dresende merged 1 commit intodresende:masterfrom
christiaanwesterbeek:master
May 16, 2015
Merged

Add support for SELECT TOP construct for mssql dialect for limit#41
dresende merged 1 commit intodresende:masterfrom
christiaanwesterbeek:master

Conversation

@christiaanwesterbeek
Copy link
Copy Markdown
Contributor

MSSQL is the only dialect supported by node-sql-query that constructs a limit as

SELECT TOP [n rows] columns
FROM tablename
ORDER BY key ASC

instead of

SELECT columns
FROM tablename
ORDER BY key ASC
LIMIT n

This commit adds support for mssql and the limit property.

@christiaanwesterbeek
Copy link
Copy Markdown
Contributor Author

@dresende Easy merge waiting (tests were added and passing)

@dresende
Copy link
Copy Markdown
Owner

Thank you

dresende added a commit that referenced this pull request May 16, 2015
Add support for SELECT TOP construct for mssql dialect for limit
@dresende dresende merged commit ed327ad into dresende:master May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants