fix bugs and add method listsinceblock#23
Conversation
|
Thanks! Now at long last belatedly merged. @mezrin, as we're looking to resurrect the project by expanding the set of maintainers for it, I've also added push access for you. Feel free to directly commit improvements in case you're still using the library. As a minor point, if you still recall, what was your rationale for changing the null checks in |
|
As I remember I had to deal with the wallet that has account with the name '0'. I.e. numeric zero. Old code throws exception for that case. (Maybe not '0', but some name that did not pass the checks). Generally Bitcoin allows to use any string as the account name. Therefore the only correct check is 'is_null'. |
|
@mezrin Thanks for the explanation, makes sense. PHP's weakly-typed |
No description provided.