Skip to content

fix bugs and add method listsinceblock#23

Merged
artob merged 2 commits intodryphp:masterfrom
mezrin:master
Aug 8, 2016
Merged

fix bugs and add method listsinceblock#23
artob merged 2 commits intodryphp:masterfrom
mezrin:master

Conversation

@mezrin
Copy link
Copy Markdown
Contributor

@mezrin mezrin commented Nov 19, 2014

No description provided.

@artob artob merged commit 4ea6f3c into dryphp:master Aug 8, 2016
@artob artob self-assigned this Aug 8, 2016
@artob
Copy link
Copy Markdown
Contributor

artob commented Aug 8, 2016

Thanks! Now at long last belatedly merged.

@mezrin, as we're looking to resurrect the project by expanding the set of maintainers for it, I've also added push access for you. Feel free to directly commit improvements in case you're still using the library.

As a minor point, if you still recall, what was your rationale for changing the null checks in sendfrom()/sendmany(): e07971b

@mezrin
Copy link
Copy Markdown
Contributor Author

mezrin commented Aug 9, 2016

As I remember I had to deal with the wallet that has account with the name '0'. I.e. numeric zero. Old code throws exception for that case. (Maybe not '0', but some name that did not pass the checks).

Generally Bitcoin allows to use any string as the account name. Therefore the only correct check is 'is_null'.
(Take into account auto-conversion of types in PHP...)

@artob
Copy link
Copy Markdown
Contributor

artob commented Aug 9, 2016

@mezrin Thanks for the explanation, makes sense. PHP's weakly-typed empty() checks indeed would include zero values and "0" strings, so makes sense to narrow it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants