Open
Conversation
Completed assignment-1 by Darshan Panesar
juliagallucci
approved these changes
Feb 17, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good. One note for conciseness: sorted_word_a == sorted_word_b already evaluates to True or False, so the manual statement is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed assignment-1 by Darshan Panesar
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
For this change I edited and completed the Python Assignment 1 - Jupyter Notebook file. Code was added for the 2 sections and some of the blocks were commented out.
What did you learn from the changes you have made?
I learned quite a bit from the first part of this module. Foremost I familiarized myself with various data types in python, how to write functions, different operations in python for specific data types, how to work with these datatypes, etc. For this section I practiced writing functions, if and else statements and returns. Once the function is written, it took various inputs (words, and Boolean) and executed lines of code depending on what inputs were given.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
n/a
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
There were some initial challenge for arranging the words such that they could be uniformly compared however I reviewed the lectures for more information and practice. I also ran into some issues using semicolons which had to be fixed to colons (something that carried over from the sql section).
How were these changes tested?
I tested the changes I made with the provided test inputs for the functions. I also checked them with my own inputs to make sure.
A reference to a related issue in your repository (if applicable)
n/a
Checklist