Open
Conversation
assignment-2 Submission by Darshan Panesar
kelichiu
approved these changes
Mar 2, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Complete
Code Execution
All code cells execute without errors.
Code Quality
Code is well-organized, concise, and includes necessary comments for clarity.
Data Handling
Data files are correctly handled and processed.
Adherence to Instructions
Follows all instructions and requirements as per the assignment.
Specific Criteria
- Reading in our files
Correctly prints out information from the first file. - Summarizing our data
Correctly defines patient_summary() function. Function processes data as per operation and outputs correctly shaped data (60 entries). - Checking for Errors
Correctly defines detect_problems() function. Function uses patient_summary() and check_zeros() to identify mean inflammation of 0 accurately.
Overall Assessment
Meets all the general and specific criteria, indicating a strong understanding of the assignment objectives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment-2 Submission by Darshan Panesar
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
For this change I edited and completed the Python Assignment 2 - Jupyter Notebook file. Code was added for the 3 sections and some of the blocks were commented out.
What did you learn from the changes you have made?
I learned how to open and read csv files. I also learned how to use the previously learned if/else/elif statements with numpy generating summary stats (e.g., mean). Lastly I learned how to use a function within a function for error checking csv files.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
n/a
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I did not really experience any challenges for this assignment. Loading the files initially took some time as they were in a different directory and I had to write code to change dir.
How were these changes tested?
I tested the written code via the included test inputs. I also tried a variety of different combinations e.g., different files, using mean, min, max, and printed out outputs. The outputs are also part of the updated file.
A reference to a related issue in your repository (if applicable)
n/a
Checklist