Open
Conversation
juliagallucci
suggested changes
Oct 21, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good, however there are a few minor errors.
For part A, You accidentally compared letters_a to itself. That condition will always be False, so the length check never triggers.
For part B, In both branches of your first if, you used .upper(), so the “case sensitive” setting doesn’t actually change anything.
Please revise.
…er length comparison
Owner
Author
|
Okay I implemented the changes. I hope this one is correct now. |
juliagallucci
approved these changes
Oct 23, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good! One note for improvement, you could simplify your code by converting case and sorting directly with sorted(), which removes the need to manually create lists or loop through each letter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I defined a module for anagram checker. I used string comparison.
What did you learn from the changes you have made?
I refreshed my memory for string comparison
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I could write an another function and use that for putting letters to a list. I did the same operation twice using the same code.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No challenges.
How were these changes tested?
I compared with the provided answers.
A reference to a related issue in your repository (if applicable)
Checklist