Skip to content

Revert "Revert "assignment_1""#5

Open
dvlaminck wants to merge 1 commit intomainfrom
revert-3-revert-1-assignment-1
Open

Revert "Revert "assignment_1""#5
dvlaminck wants to merge 1 commit intomainfrom
revert-3-revert-1-assignment-1

Conversation

@dvlaminck
Copy link
Copy Markdown
Owner

Reverts #3

@dvlaminck
Copy link
Copy Markdown
Owner Author

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding appropriate functions for the anagram checker and case-sensitive anagram checker.
What did you learn from the changes you have made?
I learned how to do conditional statements in python and making use of the built-in functions
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I initially had separated out the steps of making the words lowercase and then sorting them, but realized it was more efficient to combine them into one step.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
See above -- Trial and error to see if I could combine the functions into one step was helpful.
How were these changes tested?
I tried all my functions within the jupyter notebook to see if they were working as expected.
A reference to a related issue in your repository (if applicable)
Checklist

  •  I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants