Skip to content

Revert "Revert "assignment_2 answers""#6

Open
dvlaminck wants to merge 1 commit intomainfrom
revert-4-revert-2-assignment-2
Open

Revert "Revert "assignment_2 answers""#6
dvlaminck wants to merge 1 commit intomainfrom
revert-4-revert-2-assignment-2

Conversation

@dvlaminck
Copy link
Copy Markdown
Owner

Reverts #4

@dvlaminck
Copy link
Copy Markdown
Owner Author

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I'm adding code to assignment 2. I added multiple functions to read files and summarize them.
What did you learn from the changes you have made?
I learned how to nest functions within other functions and the power of readlines().
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I thought about using readline() sequentially as discussed in class, but realized that readlines() with a for loop was more efficient.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Determining exactly what my function should be doing was sometimes difficult, but having the expected outputs explained within the assignment instructions helped.
How were these changes tested?
My functions were ran and tested within my jupyter notebook to ensure they were working as expected.
A reference to a related issue in your repository (if applicable)
N/A
Checklist

  •  I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants