You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I'm adding code to assignment 2. I added multiple functions to read files and summarize them.
What did you learn from the changes you have made?
I learned how to nest functions within other functions and the power of readlines().
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I thought about using readline() sequentially as discussed in class, but realized that readlines() with a for loop was more efficient.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Determining exactly what my function should be doing was sometimes difficult, but having the expected outputs explained within the assignment instructions helped.
How were these changes tested?
My functions were ran and tested within my jupyter notebook to ensure they were working as expected.
A reference to a related issue in your repository (if applicable)
N/A
Checklist
I can confirm that my changes are working as intended
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4