Skip to content

[POP-2464] Pypi.org project description#50

Merged
DynataRidley merged 12 commits intodevfrom
POP-2464
Jan 27, 2020
Merged

[POP-2464] Pypi.org project description#50
DynataRidley merged 12 commits intodevfrom
POP-2464

Conversation

@DynataRidley
Copy link
Contributor

@DynataRidley DynataRidley commented Jan 23, 2020

Updated pyproject.toml with readme and repository, removed unnecessary dependencies from non-dev installations.

@DynataRidley
Copy link
Contributor Author

DynataRidley commented Jan 23, 2020

You can see how this affects the PyPI page here: https://test.pypi.org/project/dynatademand/

@RidleyLarsen
Removed setup.py and requirements.txt.
7ae2767
@RidleyLarsen
Updated github actions to use poetry to install dependencies instead …
f47f14a 
…of a requirements file.
@RidleyLarsen
Using poetry's preferred installation method to hopefully get around …
4fb09f5 
…the SolverProblemError.
@RidleyLarsen
Updated github actions to save get_poetry.py instead of output it to …
01cf4ec 
…the console.
@RidleyLarsen
Fixed spelling issue in github actions config. Added -y to poetry ins…
b7a28cb 
…tall to skip prompt.
@RidleyLarsen
Use full path to poetry to install dependencies?
aaccb8b
@RidleyLarsen
Remove python version from dev-dependencies because poetry init doesn…
66c3dd5 
…'t include it there.
@RidleyLarsen
Removed get-poetry.py after installing dependencies in GH actions.
6f40c1b
@RidleyLarsen
Removed lines for installing flake8 and pytest and added flake8 as a …
ae9f324 
…dev dependency.
@RidleyLarsen
* Updated poetry config to create virtualenv in-project while install…
865084a 
…ing.

* Updated flake8 to ignore poetry's venv.
* Updated github actions to reflect both previous changes.
@RidleyLarsen
added venv activation to pytest step because existence is pain
d75c6be
@dynata-bradley
Copy link
Contributor

dynata-bradley commented Jan 24, 2020

I don't think we can delete requirements.txt:

HAL-9000:testy wogsland$ pip install -i https://test.pypi.org/simple/ dynatademand
Looking in indexes: https://test.pypi.org/simple/
Collecting dynatademand
  Downloading https://test-files.pythonhosted.org/packages/0c/67/c24fc3d08c8d7000a882d823e1f42cc8f06411df7cfc8540e9ddca334e92/dynatademand-1.0.2.2-py2.py3-none-any.whl (23 kB)
ERROR: Could not find a version that satisfies the requirement jsonschema==3.2.0 (from dynatademand) (from versions: 3.1.2b0)
ERROR: No matching distribution found for jsonschema==3.2.0 (from dynatademand)

dynata-bradley
dynata-bradley reviewed Jan 24, 2020
View reviewed changes
dynata-bradley
dynata-bradley reviewed Jan 24, 2020
View reviewed changes
dynata-bradley
dynata-bradley reviewed Jan 24, 2020
View reviewed changes
@DynataRidley
Copy link
Contributor Author

DynataRidley commented Jan 24, 2020

jsonschema 3.2.0 hasn't been pushed to test pypi. If anything, the fact that it still tried to install that requirement means that it worked without the requirements file.

@DynataRidley DynataRidley merged commit 4cdfe28 into dev Jan 27, 2020
@dynata-bradley dynata-bradley deleted the POP-2464 branch January 27, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dynata-bradley dynata-bradley dynata-bradley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DynataRidley @dynata-bradley @RidleyLarsen