Skip to content

updating for set quotacell status endpoint#58

Merged
DynataRidley merged 4 commits intodevfrom
feat-quota-cell-status
Apr 22, 2020
Merged

updating for set quotacell status endpoint#58
DynataRidley merged 4 commits intodevfrom
feat-quota-cell-status

Conversation

@SnehaCRao
Copy link
Contributor

@SnehaCRao SnehaCRao commented Apr 2, 2020

No description provided.

@SnehaCRao
Copy link
Contributor Author

SnehaCRao commented Apr 2, 2020 •
edited
Loading

Adding new endpoint to LAUNCH/PAUSE quota cells:
{{api_host}}/sample/v1/projects/{{extProjectId}}/lineItems/{{extLineItemId}}/quotaCells/{{quotaCellId}}/pause
{{api_host}}/sample/v1/projects/{{extProjectId}}/lineItems/{{extLineItemId}}/quotaCells/{{quotaCellId}}/launch
This endpoint is yet to be added to developers.dynata.com
Will update README with this link once it is posted, and then merge the SDK changes.

dynata-bradley
dynata-bradley reviewed Apr 3, 2020
View reviewed changes
README.md Outdated
[Get Line Item Detailed Report](https://developers.dynata.com/demand-api-reference/core-resources/lineitems/get-detailed-line-item): get_line_item_detailed_report(project_id, line_item_id)
[Get Line Item Detailed Report](https://developers.dynata.com/demand-api-reference/core-resources/lineitems/get-detailed-line-item): get_line_item_detailed_report(project_id, line_item_id)

### todo: will update this once it is published in developers.dynata.com
Copy link
Contributor

@dynata-bradley dynata-bradley Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this note needs to be in the code. Why not denote it in Github and @DynataRidley will make sure to wait until the green light to release the next version to PyPi?

Copy link
Contributor Author

@SnehaCRao SnehaCRao Apr 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DynataRidley , I have updated with the changes to README. Could you kindly review.

@dynata-bradley
Copy link
Contributor

dynata-bradley commented Apr 3, 2020

I don't think I can adequately review this without having the endpoint documentation.

ashajyothi828
ashajyothi828 approved these changes Apr 21, 2020
View reviewed changes
Copy link

@ashajyothi828 ashajyothi828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine

@ashajyothi828 ashajyothi828 requested review from saadullahsaeed and removed request for ukumark April 21, 2020 07:16
@DynataRidley DynataRidley merged commit 75591c1 into dev Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashajyothi828 ashajyothi828 ashajyothi828 approved these changes

@DynataRidley DynataRidley Awaiting requested review from DynataRidley

@saadullahsaeed saadullahsaeed Awaiting requested review from saadullahsaeed

+2 more reviewers

@dynata-bradley dynata-bradley dynata-bradley left review comments

@manikanta-talanki manikanta-talanki manikanta-talanki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SnehaCRao @dynata-bradley @manikanta-talanki @ashajyothi828 @DynataRidley