Conversation
efantinatti
left a comment
There was a problem hiding this comment.
Hi @dzedze Q1 is OK. Q2 you may consider running max and mean. Q3 you may also consider testing all the files and see which of them you get the True values.
Best,
E. Fantinatti
Thank you so much for your suggestions @efantinatti , I have updated my notebook regarding those requests, including tests for "max" and "mean" for Q2, and testing all the files for Q3. |
efantinatti
left a comment
There was a problem hiding this comment.
Hi @dzedze Q3 is great! Awesome! For Q2 check if mean should be the same value as max. What about the min as well? Could you also think about testing a different parameter out of these three and see print what happens?
Best,
Thank you @efantinatti , I have added tests to:
Hope that those should cover enough edge cases. |
efantinatti
left a comment
There was a problem hiding this comment.
Hi @dzedze imoressive achievement! Congratulations. You can now merge it into main.
Best
@efantinatti
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
n.a
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
n.a
Checklist