don't pass empty string as custom installopts for numpy in test_step#1067
Merged
boegel merged 1 commit intoeasybuilders:developfrom Dec 8, 2016
Merged
don't pass empty string as custom installopts for numpy in test_step#1067boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.installoptsis initialized as empty and never touched again in thenumpyeasyblockIt is then used to pass down custom
installoptstocompose_install_commandintest_step, which makes theinstallopts is Nonecheck inPythonPackage.test_stepfail, causingself.cfg['installopts']not to be usedThis is a problem when
numpyis being installed withpip, since it means that--ignore-installed(cfr. #1066) will not be passed down when the temporary installation ofnumpyto run the tests on is being installed, resulting in thenumpybeing part of thePythoninstallation being removed...