You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@boegel I find it confusing that you add packages in __init__, even if they aren't included as sources, and then, if they are not in the sources, just ignore them. Wouldn't it be more clear (and cleaner) if setuptools (and possibly vsc-install and vsc-base, but I don't fully understand why you need them twice) is added to easybuild_pkgs if, and just if, it is listed in self.src?
@damianam I guess we could do that too, yeah. Do you want me to make that change now though? I'd like to avoid spending too much time on this now... Making changes to the EasyBuildMeta easyblock is a bit tricky, since it also affects the bootstrap script, etc.
W.r.t. vsc-base and vsc-install: this is only because those may be picked up from the OS, if a more recent vsc-base or vsc-install is available there. That mostly a concern for HPC-UGent/VSC systems, other systems most likely don't have these installed system-wide.
@boegel: "jain". Doing it now or later I think it doesn't matter. But I think it should be done. To fix #1090 and don't delay 3.1.0, I guess you can keep it as it is now, after all it doesn't affect the functionality, but open an issue with target 3.1.1 or 3.2.0 to don't forget about it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also consider
setuptoolsin case it is listed as one of the sources in theEasyBuildeasyconfig fileThis is required to work around the problem reported in #1090