Bundle: Allow per-component source_urls with templating#1108
Merged
boegel merged 1 commit intoeasybuilders:developfrom Feb 14, 2017
Merged
Bundle: Allow per-component source_urls with templating#1108boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
Member
|
@geimer Looks good, thanks! Do you have an example use case for this? |
Member
|
Makes perfect sense, I see no reason to hold this back. Thanks for the fix @geimer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including a package with template-dependent
source_urlsin a bundle doesn't work. If specified on the bundle level, the templating resolves to the bundle's values, which is in most cases plain wrong. This PR allows to specify per-componentsource_urlswith the templates resolved to the component's values.