add support for installing Intel tools that do not require license at installation time, incl. impi and imkl 2017.2.174 by ocaisa · Pull Request #1117 · easybuilders/easybuild-easyblocks

ocaisa · 2017-02-24T09:02:21Z

Just add a new variable licensed to the intelbase to switch off licence related stuff

ocaisa · 2017-02-24T09:04:10Z

Hopes to solve #1116

wpoely86 · 2017-02-24T09:10:05Z

+                'license_file': self.license_file,
+            }
+        else:
+            silent = '\n'


print a debug message that you are not going to use any license?

…we set `licensed = False`

ocaisa · 2017-02-24T09:18:40Z

        extra_vars = EasyBlock.extra_options(extra_vars)
        extra_vars.update({
            'license_activation': [ACTIVATION_LIC_SERVER, "License activation type", CUSTOM],
+            'licensed': [True, "Set to False if Intel software does not require a runtime licence", CUSTOM],


Is this name potentially misleading, of course it is still licenced but doesn't require a runtime licence, how about runtime_license?

Should I just be leveraging the existing license_activation variable, repurposing it to also handle a False value. (I tried this but it caused some weirdness)

Thoughts @boegel

I had a WIP branch where I named this requires_license, but I guess requires_runtime_license would be more accurate...

ocaisa · 2017-02-24T09:20:06Z

This successfully builds the latest MKL for me

This reverts commit 2427be1.

boegel · 2017-02-24T12:20:48Z

-        default_lic_env_var = 'INTEL_LICENSE_FILE'
-        lic_specs, self.license_env_var = find_flexlm_license(custom_env_vars=[default_lic_env_var],
-                                                              lic_specs=[self.cfg['license_file']])
+        if self.cfg['licensed']:


ideally, we would have an equivalent named argument to prepare_step, which we can leverage from easyblocks deriving from IntelBase:

something like this (logic may be a bit off, since the point of this is to avoid having to use requires_runtime_license = False in all future imkl easyconfigs):

def prepare_step(self, requires_runtime_license=True): ... if self.cfg['requires_runtime_license'] or requires_runtime_license: ...

boegel · 2017-02-24T12:22:28Z

-        silent = '\n'.join([
-            "%(activation_name)s=%(activation)s",
-            lic_file_entry,
+        if self.cfg['licensed']:


maybe it's better to use if self.runtime_license: here, which is set to something not None in prepare_step in case there is a runtime license?

boegel · 2017-02-24T12:22:59Z


-        txt += self.module_generator.prepend_paths(self.license_env_var, [self.license_file],
-                                                   allow_abs=True, expand_relpaths=False)
+        if self.cfg['licensed']:


if self.cfg['license_file']: ?

ocaisa · 2017-02-24T13:04:35Z

Ok, that still seems to be working for me, just did a rebuild

boegel · 2017-02-24T13:13:42Z

+        if not self.cfg['requires_runtime_license'] or not requires_runtime_license:
+            self.requires_runtime_license = False
+        else:
+            self.requires_runtime_license = True


how about

self.requires_runtime_license = self.cfg['requires_runtime_license'] or requires_runtime_license

Isn't this always True regardless of the easyconfig setting since the default value of requires_runtime_license is True

Rather than or, shouldn't it be and

👍 on and

ocaisa · 2017-02-24T13:57:54Z

Still works on latest MKL, I think this is good to go now

boegel · 2017-02-24T15:05:24Z

-        lic_specs, self.license_env_var = find_flexlm_license(custom_env_vars=[default_lic_env_var],
-                                                              lic_specs=[self.cfg['license_file']])
+        # Decide if we need a license or not (default is True because of defaults of individual Booleans)
+        self.requires_runtime_license = self.cfg['requires_runtime_license'] and requires_runtime_license


please initialise self.requires_runtime_license in the constructor __init__, probably to True; this is import for --module-only for example

boegel · 2017-02-24T15:06:31Z


-        txt += self.module_generator.prepend_paths(self.license_env_var, [self.license_file],
-                                                   allow_abs=True, expand_relpaths=False)
+        if self.requires_runtime_license:


we need to think about what this does under --module-only, although it may be OK since prepare_step isn't skipped then?

Yes, should be fine, if it worked before it should still work now (otherwise you would be seeing UNKNOWN being defined in modules by the existing code)

boegel · 2017-02-25T10:09:49Z

+            )
+            silent = '\n'
+
+        silent = silent.join([


this doesn't look right, this should be:

silent += '\n'.join([

Otherwise you'll be repeating the text that specifies the license several times.

See:

>>> 'x'.join(['a', 'b', 'c']) 'axbxc'

boegel · 2017-02-25T10:10:14Z

+                "Ignoring license checks: self.requires_runtime_license=%s self.cfg['requires_runtime_license']=%s"
+                % (self.requires_runtime_license, self.cfg['requires_runtime_license'])
+            )
+            silent = '\n'


this should be

silent = ''

boegel · 2017-02-25T10:11:42Z

+            self.log.debug(
+                "Ignoring license checks: self.requires_runtime_license=%s self.cfg['requires_runtime_license']=%s"
+                % (self.requires_runtime_license, self.cfg['requires_runtime_license'])
+            )


this looks overly verbose, I'd go with

self.log.debug("No license required, so not including license specifications in silent.cfg")

boegel · 2017-02-25T10:12:14Z


-        txt += self.module_generator.prepend_paths(self.license_env_var, [self.license_file],
-                                                   allow_abs=True, expand_relpaths=False)
+        if self.requires_runtime_license:


boegel · 2017-02-25T10:13:01Z

        extra_vars = EasyBlock.extra_options(extra_vars)
        extra_vars.update({
            'license_activation': [ACTIVATION_LIC_SERVER, "License activation type", CUSTOM],
+            'requires_runtime_license': [True, "Set to False if Intel software does not require a runtime licence",


maybe use "Boolean indicating whether or not a runtime license is required" ?

boegel · 2017-02-25T10:14:16Z

@ocaisa shall we also include an update to the imkl easyblock, where we call prepare_step with requires_runtime_license=False for recent imkl versions, to resolve #1116?

ocaisa · 2017-02-25T13:23:26Z

Just tested again, works for me

boegel · 2017-03-03T07:41:12Z


+    def prepare_step(self):
+        if LooseVersion(self.version) >= LooseVersion('2017.2.174'):
+            super(EB_impi, self).prepare_step(requires_runtime_license=False)


wait... do you have a reference for this?

I know you can get the Intel MPI runtime for free, but also the full thing that allows you to build/link with/to it?

@DanielTosello?

https://software.intel.com/en-us/intel-mpi-library

There is says free download at least, same as MKL, this link is maybe a bit more explicit:
https://registrationcenter.intel.com/en/forms/?productid=2558&licensetype=2

For MKL, impi, TBB, DAAL, IPP your licence is now only getting you premium support

Eek, abort, abort! That is a named user licence, not valid for HPC:

iii. NAMED-USER LICENSE: If You obtained the Materials under a named-user license, You may allow only one (1) individual to install and use the Materials on no more than three (3) computers provided that same individual is using the Materials only on one (1) computer at a time. If You obtained a time-limited named-user license, the term of Your license and your ability to use the Materials is limited to the time period of the obtained license, which is specified on Intel’s download website, specified in the applicable documentation or controlled by the license key for the Materials.

I think we can leave the option to switch off checking the licence there for people who respect this license agreement but they should need to explicitly add this to their easyconfig (and since we know the restrictions, we should perhaps warn them if they use this option).

Yes, we can provide the option, but it shouldn't be done automagically...

Doesn't matter, download of impi download for v2017.2.174 is identical, and doesn't allow you to provide a license file anymore either, so this change is required

Ok, so SHA256 sums on the 'licenced' downloads and the 'free' downloads are the same. Therefore it is no longer possible to provide your licence to these software packages and this PR can go in. People need to be careful about what they are agreeing to when they download the sources as the installation packages will no longer check your licencing during the install...so it is a case of Freeloader beware!

boegel · 2017-03-03T10:44:08Z

verified with easybuilders/easybuild-easyconfigs#4248, good to go, thanks @ocaisa!

Add support for unlicenced Intel products

40ccf79

wpoely86 reviewed Feb 24, 2017

View reviewed changes

Make sure the licence envvar doesn't end up in the final module when …

b37899f

…we set `licensed = False`

ocaisa commented Feb 24, 2017

View reviewed changes

Alan O'Cais added 3 commits February 24, 2017 10:23

Add a debug message when using the licensed setting

b3b32cb

Leverage existing variable instead of creating a new one

2427be1

Revert "Leverage existing variable instead of creating a new one"

96f32c5

This reverts commit 2427be1.

boegel requested changes Feb 24, 2017

View reviewed changes

boegel added this to the 3.2.0 milestone Feb 24, 2017

Make things a little more flexible and use a more descriptive name

bc4d95d

boegel reviewed Feb 24, 2017

View reviewed changes

Tidy up the decision logic

489b845

boegel reviewed Feb 24, 2017

View reviewed changes

Give init value to self.requires_runtime_license

f8ae94f

boegel approved these changes Feb 25, 2017

View reviewed changes

boegel requested changes Feb 25, 2017

View reviewed changes

boegel reviewed Feb 25, 2017

View reviewed changes

Alan O'Cais added 2 commits February 25, 2017 14:05

Address comments

ee1fbe2

Newer imkl versions do not require a runtime licence

23a524b

Alan O'Cais added 3 commits February 25, 2017 14:33

Use super rather than the explicit class

60be3f4

No licence for impi either

3a64bf2

Fix sloppy error

17a9d60

boegel added this to the 3.1.1 milestone Mar 3, 2017

boegel removed this from the 3.2.0 milestone Mar 3, 2017

boegel requested changes Mar 3, 2017

View reviewed changes

boegel mentioned this pull request Mar 3, 2017

MKL now free #1116

Closed

boegel changed the title ~~Add support for unlicenced Intel products~~ add support for installing Intel tools that do not require license at installation time, incl. impi and imkl 2017.2.174 Mar 3, 2017

boegel approved these changes Mar 3, 2017

View reviewed changes

boegel mentioned this pull request Mar 3, 2017

{tools}[intel/2017.02] HPL v2.2 easybuilders/easybuild-easyconfigs#4248

Merged

boegel merged commit 4b21e79 into easybuilders:develop Mar 3, 2017

boegel mentioned this pull request Mar 30, 2017

ifort-2017.2.174-GCC-6.3.0-2.27.eb contains mpi easybuilders/easybuild-easyconfigs#4410

Closed

bartoldeman added a commit to ComputeCanada/easybuild-easyblocks that referenced this pull request Apr 13, 2017

Support requires_runtime_license like in PR easybuilders#1117 for Intel.

929df40

ocaisa deleted the intelbase_nolicence branch October 27, 2021 10:40

Conversation

ocaisa commented Feb 24, 2017

Uh oh!

ocaisa commented Feb 24, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocaisa Feb 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocaisa commented Feb 24, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocaisa commented Feb 24, 2017

Uh oh!

boegel Feb 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocaisa commented Feb 24, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boegel Feb 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boegel commented Feb 25, 2017

Uh oh!

ocaisa commented Feb 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocaisa Mar 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

ocaisa Feb 24, 2017 •

edited

Loading

boegel Feb 24, 2017 •

edited

Loading

boegel Feb 25, 2017 •

edited

Loading

ocaisa Mar 3, 2017 •

edited

Loading